[SOT][Faster Guard] Implement more make_faster_guard
#72272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zrr1999
force-pushed
the
guard_tree_node
branch
from
a2de515 to
68f6833
Compare
zrr1999
changed the title
zrr1999
force-pushed
the
guard_tree_node
branch
from
8860f0d to
d13fa5f
Compare
SigureMo
reviewed
Apr 16, 2025
paddle/fluid/pybind/sot/guards.cc
Outdated
| if (value == NULL) { | ||
| PyErr_Clear(); | ||
| return false; | ||
| } |
|
…` misses `cache_index`
zrr1999
force-pushed
the
guard_tree_node
branch
from
1979a52 to
8c8dcff
Compare
SigureMo
changed the title
make_faster_guard
SigureMo
changed the title
make_faster_guardmake_faster_guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
当 STRICT_GUARD 没开启且GUARD_TREE开启时，如果guard tree没有命中，也就是cache_index为None之前会再找一次，fasterguard（pyguard），本PR把这个逻辑去掉了，guard tree没有命中则直接视为guard miss，不会再去其他guard模式找。
另外实现了下述make_faster_guard：
目前还差2个：
NumpyVariable，这个的 make_stringified_guard 也没有实现